liurenjie1024 commented on issue #586: URL: https://github.com/apache/iceberg-rust/issues/586#issuecomment-2323635619
Hi, @yukkit Thanks for your interest and welcome to contribute! > For the first question: > > 1. By default, use the latest version. > 2. [Optional] Support specifying a version, for example: CREATE EXTERNAL TABLE my_table STORED AS ICEBERGTABLE LOCATION '/path/to/table' OPTIONS ('version' '1'); As with this problem, how about we ask user to point the path to a table metadata file directly? The path + version approach is not clear about what this version means. For example, if the user is trying to reading a table managed by sql/hive catalogs, metadata file names are typically suffixed by uuids. Also `version` maybe confusing to users familiar with iceberg, since that typicall means snapshot version. > For the second question: > > 1. Specify the relevant parameters in the OPTIONS block of the DDL statement. > 2. Refactor FileIO so that it also can rely on ObjectStore as its storage backend. > 3. Register the FileIO used to read the location via a global variable. I'm +1 for option 1. While 2 and 3 are worth dicussiong options for improving FileIO, this use case doesn't seem a solid motivation. Also we don't need to ask user to provide credentials in config block, since currently opendal s3 operators could load for env: https://docs.rs/opendal/latest/opendal/services/struct.S3Config.html#structfield.disable_config_load . cc @Xuanwo to confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org