hsiang-c commented on code in PR #9335:
URL: https://github.com/apache/iceberg/pull/9335#discussion_r1742044457
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -530,12 +530,13 @@ public void testFilesTableTimeTravelWithSchemaEvolution()
throws Exception {
+ tableName
+ ".files VERSION AS OF "
+ currentSnapshotId
- + " ORDER BY content");
+ + " ORDER BY file_path");
List<Row> actualFiles =
TestHelpers.selectNonDerived(actualFilesDs).collectAsList();
Schema entriesTableSchema = Spark3Util.loadIcebergTable(spark, tableName +
".entries").schema();
List<ManifestFile> expectedDataManifests =
TestHelpers.dataManifests(table);
List<Record> expectedFiles =
expectedEntries(table, FileContent.DATA, entriesTableSchema,
expectedDataManifests, null);
+ expectedFiles.sort(Comparator.comparing(r ->
r.get("file_path").toString()));
Review Comment:
Ordering by `file_path` for both actual files and expected files sorts both
list deterministically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
