nastra commented on code in PR #10953:
URL: https://github.com/apache/iceberg/pull/10953#discussion_r1749992612
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -140,14 +141,16 @@ public static class ConstantVectorHolder<T> extends
VectorHolder {
private final int numRows;
public ConstantVectorHolder(int numRows) {
+ super(new NullVector("_dummy_", numRows), null, null);
this.numRows = numRows;
this.constantValue = null;
}
public ConstantVectorHolder(Types.NestedField icebergField, int numRows, T
constantValue) {
- super(icebergField);
+ super(new NullVector(icebergField.name(), numRows), icebergField, new
NullabilityHolder(numRows));
this.numRows = numRows;
this.constantValue = constantValue;
+ this.vector = new NullVector(icebergField.name(), numRows);
Review Comment:
I don't think we should be creating two instances of `NullVector`. Either
use the one you pass via `super(...)` or this one, but not both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
