nastra commented on code in PR #10996:
URL: https://github.com/apache/iceberg/pull/10996#discussion_r1750200212
##########
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java:
##########
@@ -27,33 +27,23 @@
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
import org.apache.iceberg.Schema;
import org.apache.iceberg.common.DynMethods;
-import org.apache.iceberg.hive.HiveVersion;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.TypeUtil;
import org.apache.iceberg.types.Types;
public final class IcebergObjectInspector extends
TypeUtil.SchemaVisitor<ObjectInspector> {
- // get the correct inspectors depending on whether we're working with Hive2
or Hive3 dependencies
- // we need to do this because there is a breaking API change in
Date/TimestampObjectInspector
- // between Hive2 and Hive3
private static final String DATE_INSPECTOR_CLASS =
- HiveVersion.min(HiveVersion.HIVE_3)
- ?
"org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspectorHive3"
- :
"org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspector";
+
"org.apache.iceberg.mr.hive.serde.objectinspector.IcebergDateObjectInspector";
Review Comment:
maybe just rename those classes so that they don't have the `Hive` suffix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
