bryanck commented on code in PR #11100:
URL: https://github.com/apache/iceberg/pull/11100#discussion_r1750375359
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -79,6 +79,8 @@ public class IcebergSinkConfig extends AbstractConfig {
"iceberg.tables.schema-force-optional";
private static final String TABLES_SCHEMA_CASE_INSENSITIVE_PROP =
"iceberg.tables.schema-case-insensitive";
+ private static final String TABLES_SCHEMA_FORCE_COLUMNS_TO_LOWERCASE_PROP =
+ "iceberg.tables.schema-force-columns-to-lowercase";
Review Comment:
I think `iceberg.tables.schema-force-lowercase` is sufficient and consistent
with `schema-force-optional`. Also, moving this up one to be below
`schema-force optional` would be preferable.
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -162,6 +164,12 @@ private static ConfigDef newConfigDef() {
false,
Importance.MEDIUM,
"Set to true to look up table columns by case-insensitive name, false
for case-sensitive");
+ configDef.define(
+ TABLES_SCHEMA_FORCE_COLUMNS_TO_LOWERCASE_PROP,
+ ConfigDef.Type.BOOLEAN,
+ false,
+ Importance.MEDIUM,
+ "Set to true to force table column names to lowercase, false for
preserve case");
Review Comment:
Same note here on name and moving it up one element to be next to "force
optional".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
