amogh-jahagirdar commented on code in PR #9695: URL: https://github.com/apache/iceberg/pull/9695#discussion_r1750572264
########## open-api/rest-catalog-open-api.yaml: ########## @@ -3647,6 +4080,105 @@ components: type: integer description: "List of equality field IDs" + PlanTableScanRequest: + type: object + properties: + snapshot-id: + description: + Identifier for the snapshot to scan in a point-in-time scan + type: integer + format: int64 + select: + description: List of selected schema fields + type: array + items: + $ref: '#/components/schemas/FieldName' + filter: + description: + Expression used to filter the table data + $ref: '#/components/schemas/Expression' + case-sensitive: + description: Enables case sensitive field matching for filter and select + type: boolean + default: true + use-snapshot-schema: + description: + Whether to use the schema at the time the snapshot was written. + + When time travelling, the snapshot schema should be used (true). Review Comment: Yeah, clients currently specify the snapshot ID however there needs to be a mechanism for distinguishing which schema gets used based on if it's a time travel by a specific snapshot ID or if it's a time travel by branch. The client has that context, and it's easier for it to determine which schema should be used. The request input is kept simpler by having just a snapshot ID for time travel as @danielcweeks said rather than having a mix of different options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org