hesham-medhat commented on code in PR #11039:
URL: https://github.com/apache/iceberg/pull/11039#discussion_r1755319360
##########
build.gradle:
##########
@@ -647,20 +647,43 @@ project(':iceberg-gcp') {
implementation project(':iceberg-common')
implementation project(':iceberg-core')
+
implementation("com.google.apis:google-api-services-bigquery:v2-rev20240602-2.0.0")
Review Comment:
Hmm..we could do it but it would break the pattern similar to how we have
the project `:iceberg-hive-metastore` with everything Hive in there, both
related to storage and metadata.
This project is also named :iceberg-gcp and BigQuery is part of GCP. So we
could have two projects `iceberg-bigquery` and `iceberg-gcs` or so if you want,
but I think it's honestly fine, this is just an API client library and I think
it belongs here as the BigQuery code does use a fair amount of these
dependencies anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
