fengjiajie commented on PR #11073: URL: https://github.com/apache/iceberg/pull/11073#issuecomment-2345730971
@pvary: Thanks for your reply. I've reviewed all the places where `ThreadPools.newWorkerPool` is used. It seems that only a few of them are static and long-lived. Most of the others are explicitly shut down. Given this, do you think it makes sense to modify `ThreadPools.newWorkerPool` to not wrap it with `ExitingExecutorService` by default? This is to prevent potential issues where other developers might use `ThreadPools.newWorkerPool` without realizing that it registers a shutdown hook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
