sungwy commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1757539710
##########
tests/integration/test_inspect_table.py:
##########
@@ -672,126 +672,141 @@ def test_inspect_files(
# append more data
tbl.append(arrow_table_with_null)
- df = tbl.refresh().inspect.files()
+ # configure table properties
+ if format_version == 2:
+ with tbl.transaction() as txn:
+ txn.set_properties({"write.delete.mode": "merge-on-read"})
+ spark.sql(f"DELETE FROM {identifier} WHERE int = 1")
Review Comment:
> Spark only produces positional delete files. Flink might produce equality
delete files.
That's my understanding as well. I think just testing for positional deletes
is okay for now, and maybe we can think of ways in adding equality deletes in
our test suite in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
