sungwy commented on code in PR #1185:
URL: https://github.com/apache/iceberg-python/pull/1185#discussion_r1767792939
##########
pyiceberg/table/snapshots.py:
##########
@@ -249,6 +241,9 @@ class Snapshot(IcebergBaseModel):
summary: Optional[Summary] = Field(default=None)
schema_id: Optional[int] = Field(alias="schema-id", default=None)
+ # Private attribute for caching the manifests
+ _manifest_cache: Optional[List[ManifestFile]] = PrivateAttr(default=None)
Review Comment:
This looks promising @kevinjqliu
I know this is a regression from the intended optimization at the module
level as suggested here:
https://github.com/apache/iceberg-python/pull/787#discussion_r1632224368 but I
don't think we have a better alternative 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
