amogh-jahagirdar commented on code in PR #11092:
URL: https://github.com/apache/iceberg/pull/11092#discussion_r1769326601
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -43,9 +43,19 @@ public interface ContentFile<F> {
*/
FileContent content();
- /** Returns fully qualified path to the file, suitable for constructing a
Hadoop Path. */
+ /**
+ * Returns fully qualified path to the file, suitable for constructing a
Hadoop Path.
+ *
+ * @deprecated since 1.7.0, will be removed in 2.0.0; use {@link
#location()} instead.
+ */
+ @Deprecated
CharSequence path();
+ /** Return the fully qualified path to the file, suitable for constructing a
Hadoop Path */
Review Comment:
Discussed with @rdblue @danielcweeks and here are some key points on why we
shouldn't document anything related to hadoop:
1. Hadoop pathing doesn't work with storage systems like GCS
2. Locations are a super set of what can be represented in a hadoop path.
Even today `path` API can return paths which simply cannot be represented in a
hadoop Path.
3. The hadoop path normalization logic simply conflicts with absolute paths
So updated to remove this part of the comment. I'll leave the existing
`path` API comment as is since it's being deprecated anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
