aokolnychyi commented on code in PR #11199:
URL: https://github.com/apache/iceberg/pull/11199#discussion_r1776092317
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -458,14 +457,14 @@ DeleteFileIndex build() {
}
private void add(
- CharSequenceMap<PositionDeletes> deletesByPath,
+ Map<String, PositionDeletes> deletesByPath,
PartitionMap<PositionDeletes> deletesByPartition,
DeleteFile file) {
- CharSequence path = ContentFileUtil.referencedDataFile(file);
+ String path = ContentFileUtil.referencedDataFileLocation(file);
PositionDeletes deletes;
if (path != null) {
- deletes = deletesByPath.computeIfAbsent(path, PositionDeletes::new);
+ deletes = deletesByPath.computeIfAbsent(path, somePath -> new
PositionDeletes());
Review Comment:
Minor: `somePath` -> `ignored` or `key`? We use this style in a few places,
I think it highlights the key is not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
