amogh-jahagirdar commented on code in PR #11273:
URL: https://github.com/apache/iceberg/pull/11273#discussion_r1792703916
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -449,8 +493,33 @@ protected PartitioningWriter<PositionDelete<InternalRow>,
DeleteWriteResult> new
writers, files, io, targetFileSize, deleteGranularity);
} else {
return new FanoutPositionOnlyDeleteWriter<>(
- writers, files, io, targetFileSize, deleteGranularity);
+ writers,
Review Comment:
Ah, yeah that's important. We'd be losing out on synchronous maintenance for
the cases the input is ordered and there's file scoped deletes, if we didn't
update to use fanout writers there.... I'll fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
