jinyangli34 commented on code in PR #11258:
URL: https://github.com/apache/iceberg/pull/11258#discussion_r1792875688
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -66,6 +66,9 @@ class ParquetWriter<T> implements FileAppender<T>, Closeable {
private boolean closed;
private ParquetFileWriter writer;
private int rowGroupOrdinal;
+ private long currentRawBufferedSize = 0;
Review Comment:
each row group data has two different sizes:
1. in memory before written (in_memory_size)
2. written as complete row group (written_size)
currentRawBufferedSize: "in_memory" of current unfinished row group
toatalRawBufferedSIze: sum(in_memory for rg in finished_row_groups)
totalRowGroupSize: sum(written for rg in finished_row_groups)
we use (toatalRawBufferedSIze / totalRowGroupSize) ratio to estimate size
change from in-memory to written state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
