emkornfield commented on code in PR #10955:
URL: https://github.com/apache/iceberg/pull/10955#discussion_r1792888066
##########
format/spec.md:
##########
@@ -1089,6 +1118,7 @@ The types below are not currently valid for bucketing,
and so are not hashed. Ho
| Primitive type | Hash specification | Test value
|
|--------------------|-------------------------------------------|--------------------------------------------|
+| **`unknown`** | `hashInt(0)` |
|
Review Comment:
Sorry I missed this on my prior reviews, but shouldn't unknown be treated as
null and return null for any cases that require a hash (also was `bucket[N]`
included to be defined for 'unknown' if not then I think the only other case is
puffin files which are today always defined as the hash of the values)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
