rdblue commented on a change in pull request #1322:
URL: https://github.com/apache/iceberg/pull/1322#discussion_r468711615



##########
File path: api/src/main/java/org/apache/iceberg/ExpireSnapshots.java
##########
@@ -96,7 +96,7 @@
    * @param executorService an executor service to parallelize tasks to delete 
manifests and data files
    * @return this for method chaining
    */
-  ExpireSnapshots executeWith(ExecutorService executorService);

Review comment:
       Can we add the new name in parallel and deprecate this name? We should 
be careful about changes to the public API and give people at least a release 
to switch over before removing public methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to