nastra commented on code in PR #10873:
URL: https://github.com/apache/iceberg/pull/10873#discussion_r1795610952
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1103,6 +1103,7 @@ class LoadTableResult(BaseModel):
## General Configurations
- `token`: Authorization bearer token to use for table requests if OAuth2
security is enabled
+ - `expires-at-ms`: if present, specifies timestamp in milliseconds when
credentials for storage(AWS S3/Azure/GCP), specified in config would expire
Review Comment:
I don't think it's actually correct to have this at this level. This should
be specific to the underlying Storage provider. GCS for example has
`gcs.oauth2.token-expires-at`. That being said, the respective FileIO
properties of each storage provider should have a similar property to the one
used for GCS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
