nastra commented on code in PR #11093:
URL: https://github.com/apache/iceberg/pull/11093#discussion_r1796545689
##########
open-api/src/testFixtures/java/org/apache/iceberg/rest/RESTCatalogServer.java:
##########
@@ -64,7 +65,9 @@ public Map<String, String> configuration() {
private CatalogContext initializeBackendCatalog() throws IOException {
// Translate environment variables to catalog properties
- Map<String, String> catalogProperties =
RCKUtils.environmentCatalogConfig();
+ Map<String, String> catalogProperties = Maps.newHashMap();
+ catalogProperties.putAll(RCKUtils.environmentCatalogConfig());
+ catalogProperties.putAll(Maps.fromProperties(System.getProperties()));
Review Comment:
as mentioned in a comment further above, maybe we should consider passing a
Map<String, String> to `RESTCatalogServer` rather than relying on system
properties (which have to be cleared after they were configured)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
