mrcnc commented on code in PR #11294:
URL: https://github.com/apache/iceberg/pull/11294#discussion_r1797403156
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSLocation.java:
##########
@@ -18,24 +18,34 @@
*/
package org.apache.iceberg.azure.adlsv2;
+import java.net.URI;
+import java.net.URISyntaxException;
import java.util.Optional;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.apache.iceberg.exceptions.ValidationException;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
/**
- * This class represents a fully qualified location in Azure expressed as a
URI.
+ * This class represents a fully qualified location in Azure Data Lake
Storage, expressed as a URI.
*
* <p>Locations follow the conventions used by Hadoop's Azure support, i.e.
*
- * <pre>{@code abfs[s]://[<container>@]<storage account host>/<file
path>}</pre>
+ * <pre>{@code
abfs[s]://[<container>@]<storageAccount>.dfs.core.windows.net/<path>}</pre>
Review Comment:
I see the ambiguity here so I changed the variable to use `storageEndpoint`
to clarify. Previously we were using the `storageAccount` variable to store
the entire endpoint's hostname and not the storage account's name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
