anuragmantri commented on code in PR #11304:
URL: https://github.com/apache/iceberg/pull/11304#discussion_r1797771433
##########
api/src/main/java/org/apache/iceberg/util/CharSequenceMap.java:
##########
@@ -132,12 +133,12 @@ public Set<CharSequence> keySet() {
keySet.add(wrapper.get());
}
- return keySet;
+ return Collections.unmodifiableSet(keySet);
Review Comment:
Thanks @findepi. Let me check the other map implementations and make sure
they follow the
[Map](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Map.html)
contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
