zeroshade commented on code in PR #169:
URL: https://github.com/apache/iceberg-go/pull/169#discussion_r1800098570
##########
catalog/glue.go:
##########
@@ -150,8 +151,33 @@ func (c *GlueCatalog) UpdateNamespaceProperties(ctx
context.Context, namespace t
return PropertiesUpdateSummary{}, fmt.Errorf("%w: [Glue Catalog] update
namespace properties", iceberg.ErrNotImplemented)
}
+// ListNamespaces returns a list of Iceberg namespaces from the given Glue
catalog.
func (c *GlueCatalog) ListNamespaces(ctx context.Context, parent
table.Identifier) ([]table.Identifier, error) {
- return nil, fmt.Errorf("%w: [Glue Catalog] list namespaces",
iceberg.ErrNotImplemented)
+ params := &glue.GetDatabasesInput{}
+
+ if parent != nil {
+ return nil, fmt.Errorf("hierarchical namespace is not
supported")
+ }
Review Comment:
Is this a facet of glue? Or are we just not implementing it yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
