tomtongue commented on code in PR #11262:
URL: https://github.com/apache/iceberg/pull/11262#discussion_r1800744929
##########
api/src/test/java/org/apache/iceberg/ParameterizedTestExtension.java:
##########
@@ -225,7 +222,11 @@ private Stream<TestTemplateInvocationContext>
createContextForParameters(
Stream<Object[]> parameterValueStream, String testNameTemplate,
ExtensionContext context) {
// Search fields annotated by @Parameter
final List<Field> parameterFields =
- AnnotationSupport.findAnnotatedFields(context.getRequiredTestClass(),
Parameter.class);
+ AnnotationSupport.findAnnotatedFields(
+ context.getRequiredTestClass(),
+ Parameter.class,
+ field -> true,
+ HierarchyTraversalMode.TOP_DOWN);
Review Comment:
Sorry I missed that, you're correct. Let me fix this and other parts. Thank
you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
