steveloughran commented on code in PR #11021:
URL: https://github.com/apache/iceberg/pull/11021#discussion_r1803574204
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -298,8 +303,13 @@ private List<String> deleteBatch(String bucket,
Collection<String> keysToDelete)
@Override
public Iterable<FileInfo> listPrefix(String prefix) {
S3URI s3uri = new S3URI(prefix,
s3FileIOProperties.bucketToAccessPointMapping());
+ String suffix = "";
Review Comment:
...but the HadoopFileIO class explicitly maps prefix ==> directory.
Therefore nobody is calling it passing in an arbitrary prefix. Therefore unless
someone is calling S3FileIO or planning a regression which completely breaks
iceberg listings against HDFS, S3A etc, it'll stay a prefix.
That said: javadocs might need a change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
