bryanck commented on code in PR #11303:
URL: https://github.com/apache/iceberg/pull/11303#discussion_r1803734111
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -406,6 +406,10 @@ public JsonConverter jsonConverter() {
return jsonConverter;
}
+ static boolean checkClassName(String className) {
Review Comment:
One more nit, could you add `@VisibleForTesting`? That makes it clear why it
isn't private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
