amogh-jahagirdar commented on code in PR #11335:
URL: https://github.com/apache/iceberg/pull/11335#discussion_r1803860896
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestFlakyS3InputStream.java:
##########
@@ -49,10 +51,29 @@
public class TestFlakyS3InputStream extends TestS3InputStream {
+ private AtomicInteger resetForRetryCounter;
+
+ @BeforeEach
+ public void setupTest() {
+ resetForRetryCounter = new AtomicInteger(0);
+ }
+
+ @Override
+ S3InputStream newInputStream(S3Client s3Client, S3URI uri) {
+ return new S3InputStream(s3Client, uri) {
+ @Override
+ void resetForRetry() throws IOException {
+ resetForRetryCounter.incrementAndGet();
+ super.resetForRetry();
+ }
Review Comment:
Thanks for fixing this, this was crucial for verifying the retry behavior
actually resets the input stream. Seems like we were just getting lucky on the
tests before since they only counted the number of attempts but not what was
actually happening *in* the attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
