amogh-jahagirdar commented on code in PR #11173:
URL: https://github.com/apache/iceberg/pull/11173#discussion_r1804878848
##########
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java:
##########
@@ -74,12 +83,17 @@ public Map<String, String> config() {
return config != null ? config : ImmutableMap.of();
}
+ public List<Credential> credentials() {
+ return credentials != null ? credentials : ImmutableList.of();
+ }
+
@Override
public String toString() {
return MoreObjects.toStringHelper(this)
.add("metadataLocation", metadataLocation)
.add("metadata", metadata)
.add("config", config)
+ .add("credentials", credentials)
Review Comment:
I'm not sure we should be adding this to the `toString`? Bit concerned if
someone is inadvertently logging load table response then they'd be logging
sensitive info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
