nastra commented on code in PR #11264:
URL: https://github.com/apache/iceberg/pull/11264#discussion_r1806145764
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##########
@@ -217,27 +217,27 @@ public void testPrimitiveColumns() throws Exception {
Row binaryCol =
Row.of(
- 52L,
+ 55L,
Review Comment:
looks like column sizes got slightly larger:
Parquet 1.13.1
```
% parquet-cli/1.14.3/bin/parquet column-size old-version.parquet
binaryCol-> Size In Bytes: 52 Size In Ratio: 0.08695652
intCol-> Size In Bytes: 71 Size In Ratio: 0.1187291
decimalCol-> Size In Bytes: 85 Size In Ratio: 0.14214046
fixedCol-> Size In Bytes: 44 Size In Ratio: 0.073578596
booleanCol-> Size In Bytes: 32 Size In Ratio: 0.053511705
stringCol-> Size In Bytes: 79 Size In Ratio: 0.13210702
floatCol-> Size In Bytes: 71 Size In Ratio: 0.1187291
longCol-> Size In Bytes: 79 Size In Ratio: 0.13210702
doubleCol-> Size In Bytes: 85 Size In Ratio: 0.14214046
```
Parquet 1.14.3
```
% parquet-cli/1.14.3/bin/parquet column-size new-version.parquet
binaryCol-> Size In Bytes: 55 Size In Ratio: 0.085403726
intCol-> Size In Bytes: 77 Size In Ratio: 0.11956522
decimalCol-> Size In Bytes: 91 Size In Ratio: 0.14130434
fixedCol-> Size In Bytes: 47 Size In Ratio: 0.072981365
booleanCol-> Size In Bytes: 36 Size In Ratio: 0.055900622
stringCol-> Size In Bytes: 85 Size In Ratio: 0.13198757
floatCol-> Size In Bytes: 77 Size In Ratio: 0.11956522
longCol-> Size In Bytes: 85 Size In Ratio: 0.13198757
doubleCol-> Size In Bytes: 91 Size In Ratio: 0.14130434
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
