leesf commented on code in PR #11352:
URL: https://github.com/apache/iceberg/pull/11352#discussion_r1806236088
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -77,6 +83,51 @@ public static TableMetadata newTableMetadata(
return newTableMetadata(schema, spec, SortOrder.unsorted(), location,
properties);
}
+ /**
+ * Deletes the oldest metadata files if {@link
+ * TableProperties#METADATA_DELETE_AFTER_COMMIT_ENABLED} is true.
+ *
+ * @param io file IO
+ * @param base table metadata on which previous versions were based
+ * @param metadata new table metadata with updated previous versions
+ */
+ public static void deleteRemovedMetadataFiles(
Review Comment:
@nastra because currently the `deleteRemovedMetadataFiles` method lies both
in `HadoopTableOperations` and `BaseMetastoreTableOperations` and cause
duplicate code, the place i would think is moving this method here, or what do
you have better idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
