ookumuso commented on code in PR #11112:
URL: https://github.com/apache/iceberg/pull/11112#discussion_r1806988739
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -108,10 +108,15 @@ public String newDataLocation(String filename) {
static class ObjectStoreLocationProvider implements LocationProvider {
private static final HashFunction HASH_FUNC = Hashing.murmur3_32_fixed();
- private static final BaseEncoding BASE64_ENCODER =
BaseEncoding.base64Url().omitPadding();
- private static final ThreadLocal<byte[]> TEMP = ThreadLocal.withInitial(()
-> new byte[4]);
+ // the starting index of the lower 20-bits of a 32-bit binary string
+ private static final int HASH_BINARY_STRING_START_INDEX = 12;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
