danielcweeks commented on code in PR #11368:
URL: https://github.com/apache/iceberg/pull/11368#discussion_r1811223257
##########
api/src/main/java/org/apache/iceberg/UpdatePartitionSpec.java:
##########
@@ -133,4 +133,16 @@ default UpdatePartitionSpec addNonDefaultSpec() {
throw new UnsupportedOperationException(
this.getClass().getName() + " doesn't implement addNonDefaultSpec()");
}
+
+ /**
+ * Explicitly providing the partition spec that we would like to use. When a
spec has been
+ * provided then modifications should not be done afterwards through this
class.
+ *
+ * @param newSpec partition spec to override the builder use during commit
+ * @return this for method chaining names.
+ */
+ default UpdatePartitionSpec useSpec(PartitionSpec newSpec) {
Review Comment:
I agree, this feels hacky. I'm also not convinced it goes through the right
validations. We probably want to walk diff the specs and make the necessary
updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
