jinyangli34 commented on code in PR #11258:
URL: https://github.com/apache/iceberg/pull/11258#discussion_r1811499959
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -557,8 +557,8 @@ public void testBinPackCombineMixedFiles() {
@Test
public void testBinPackCombineMediumFiles() {
- Table table = createTable(4);
- shouldHaveFiles(table, 4);
+ Table table = createTable(6);
+ shouldHaveFiles(table, 6);
Review Comment:
4/3 may produce groups with [1.4, 1.3, 1.3] or [1.3, 1.3, 1.3, 0.1]
The testing data generates [197078, 188542, 189047, 15617] with small tail.
Using 4/2 or 6/3 can make test more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
