sundy-li commented on code in PR #677:
URL: https://github.com/apache/iceberg-rust/pull/677#discussion_r1812226077
##########
crates/iceberg/src/arrow/record_batch_transformer.rs:
##########
@@ -154,10 +142,15 @@ impl RecordBatchTransformer {
Some(BatchTransform::Modify {
ref target_schema,
ref operations,
- }) => RecordBatch::try_new(
- target_schema.clone(),
- self.transform_columns(record_batch.columns(), operations)?,
- )?,
+ }) => {
+ let options =
Review Comment:
Empty array is ok in `RecordBatch`, but we need to inject the rows for empty
arrays.
The new test case already covers the empty scans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
