rodmeneses commented on code in PR #11348:
URL: https://github.com/apache/iceberg/pull/11348#discussion_r1813237820
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/TypeToFlinkType.java:
##########
@@ -113,6 +113,15 @@ public LogicalType primitive(Type.PrimitiveType primitive)
{
// MICROS
return new TimestampType(6);
}
+ case TIMESTAMP_NANO:
+ Types.TimestampNanoType timestampNano = (Types.TimestampNanoType)
primitive;
+ if (timestampNano.shouldAdjustToUTC()) {
+ // NANOS
Review Comment:
to be consistent with current comments already present for `MICROS`, ie:
```java
if (timestamp.shouldAdjustToUTC()) {
// MICROS
return new LocalZonedTimestampType(6);
} else {
// MICROS
return new TimestampType(6);
}
```
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/TypeToFlinkType.java:
##########
@@ -113,6 +113,15 @@ public LogicalType primitive(Type.PrimitiveType primitive)
{
// MICROS
return new TimestampType(6);
}
+ case TIMESTAMP_NANO:
+ Types.TimestampNanoType timestampNano = (Types.TimestampNanoType)
primitive;
+ if (timestampNano.shouldAdjustToUTC()) {
+ // NANOS
+ return new LocalZonedTimestampType(9);
+ } else {
+ // NANOS
Review Comment:
please see above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
