rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815789874
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -562,7 +563,7 @@ private static String sanitize(Literal<?> literal, long
now, int today) {
} else if (literal instanceof Literals.DoubleLiteral) {
return sanitizeNumber(((Literals.DoubleLiteral) literal).value(),
"float");
} else {
- // for uuid, decimal, fixed, and binary, match the string result
+ // for uuid, decimal, fixed, variant, and binary, match the string result
Review Comment:
This is _okay_ but we may be missing information by not sanitizing based on
the variant's type (i.e. date) and it would be nice to have some idea of the
structure in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
