RussellSpitzer commented on code in PR #11157:
URL: https://github.com/apache/iceberg/pull/11157#discussion_r1817300773
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -711,7 +719,7 @@ public static void importSparkPartitions(
spec,
stagingDir,
checkDuplicateFiles,
- TableMigrationUtil.migrationService(parallelism));
+ executorService(parallelism));
Review Comment:
How difficult is it for us to change this to a Supplier? I'm basically
thinking that the current fix is basically creating a LazyExecutorService but
we know actually passing a non-lazy executor service will always be broken. If
this is the case shouldn't we pass through a Serializable Supplier for an
Executor Service?
Based on your comments below it seems like this api is just broken as is. I
think i may agree more with @nastra now that maybe we just remove the ability
to pass through executor service? I'm not sure now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
