pvary commented on code in PR #11386:
URL: https://github.com/apache/iceberg/pull/11386#discussion_r1817698482
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkAvroReaderWriter.java:
##########
@@ -91,7 +91,7 @@ private void writeAndValidate(Schema schema, List<Record>
expectedRecords, int n
try (CloseableIterable<RowData> reader =
Avro.read(Files.localInput(recordsFile))
.project(schema)
- .createReaderFunc(FlinkAvroReader::new)
+ .createResolvingReader(FlinkPlannedAvroReader::create)
Review Comment:
QQ: Do we have remaining tests for the old reader? I usually try to keep at
least a few tests for the deprecated features as well, so they are not broken
unintentionally by future changes (and mark them as deprecated, so we don't
forget to remove them when the feature is removed).
If there are other tests? Do we test the same functions for the new reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
