shivjha30 commented on code in PR #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r1818346539
##########
build.gradle:
##########
@@ -247,13 +250,30 @@ project(':iceberg-data') {
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
}
- testCompile("org.apache.hadoop:hadoop-client") {
+ implementation("org.apache.orc:orc-core::nohive") {
+ exclude group: 'org.apache.hadoop'
+ exclude group: 'commons-lang'
+ // These artifacts are shaded and included in the orc-core fat jar
+ exclude group: 'com.google.protobuf', module: 'protobuf-java'
Review Comment:
@nastra
Is it intended for the protobuf-java class coming from ORC, to be part of
the runtime jar ?
For example:
org/apache/iceberg/shaded/org/apache/orc/protobuf/CodedInputStream$ArrayDecoder.class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
