RussellSpitzer commented on code in PR #11419:
URL: https://github.com/apache/iceberg/pull/11419#discussion_r1821107711
##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -164,7 +167,8 @@ private void updateColumn(Types.NestedField field,
Types.NestedField existingFie
boolean needsOptionalUpdate = field.isOptional() &&
existingField.isRequired();
boolean needsTypeUpdate =
- field.type().isPrimitiveType() &&
!field.type().equals(existingField.type());
+ (field.type().isPrimitiveType() &&
!field.type().equals(existingField.type()))
Review Comment:
I think we may just want to extract all of this logic now into a helper
function since we already have some of it in ignorableUpdate. We also only
probably need to pass through the types rather than the whole field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
