szehon-ho commented on code in PR #11414:
URL: https://github.com/apache/iceberg/pull/11414#discussion_r1821309914
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -166,7 +166,6 @@ public CloseableIterable<StructLike> rows() {
if (readableMetricsField == null) {
return CloseableIterable.transform(files(projection), file ->
(StructLike) file);
} else {
-
Review Comment:
oh yea it is definitely subjective, i remember vaguely Anton suggest some
newlines after else for better readability at some point for my prs (not sure
for this particular line or not). Id say just remove it to minimize the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
