RussellSpitzer commented on code in PR #11373:
URL: https://github.com/apache/iceberg/pull/11373#discussion_r1821560025
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetSchemaUtil.java:
##########
@@ -464,4 +588,103 @@ private Type map(Integer id, String name, Repetition
repetition, Type keyType, T
}
return builder.named(name);
}
+
+ @Test
+ public void testPruneColumns1() {
+ MessageType messageType = ParquetSchemaUtil.convert(ICEBERG_SCHEMA,
"schema");
+ Type visit =
+ TypeWithSchemaVisitor.visit(
+ ICEBERG_SCHEMA.asStruct(), messageType, new
PruneColumns(ImmutableSet.of(6, 7, 8)));
+ String expectedType =
Review Comment:
Why are we using the String? Could we just build up a Schema object with the
correct layout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
