RussellSpitzer commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1826211841
##########
api/src/main/java/org/apache/iceberg/types/Type.java:
##########
@@ -92,6 +93,10 @@ default boolean isListType() {
return false;
}
+ default boolean isVariantType() {
Review Comment:
This is only used in a deprecated method, do we have any other reason to add
this? I think it probably doesn't need to be apart of the type interface. We
could always just check if the type is VARIANT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]