aokolnychyi commented on code in PR #11443:
URL: https://github.com/apache/iceberg/pull/11443#discussion_r1826536833
##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -339,6 +344,9 @@ protected <T> void internalSet(int pos, T value) {
this.sortOrderId = (Integer) value;
return;
case 17:
+ this.referencedDataFile = value != null ? value.toString() : null;
+ return;
+ case 18:
Review Comment:
Thanks for confirming!
##########
api/src/main/java/org/apache/iceberg/DeleteFile.java:
##########
@@ -31,4 +31,15 @@ public interface DeleteFile extends ContentFile<DeleteFile> {
default List<Long> splitOffsets() {
return null;
}
+
+ /**
+ * Returns the location of a data file that all deletes reference.
+ *
+ * <p>The referenced data file is required for deletion vectors and may be
optionally captured for
+ * position delete files that apply to only one data file. This method
always returns mull for
Review Comment:
Good catch, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
