aokolnychyi commented on code in PR #11446:
URL: https://github.com/apache/iceberg/pull/11446#discussion_r1826603449
##########
api/src/main/java/org/apache/iceberg/AddedRowsScanTask.java:
##########
@@ -55,7 +56,7 @@ default ChangelogOperation operation() {
@Override
default long sizeBytes() {
- return length() +
deletes().stream().mapToLong(ContentFile::fileSizeInBytes).sum();
+ return length() + ContentFileUtil.contentSizeInBytes(deletes());
Review Comment:
This logic is in `api`. I initially moved `ContentFileUtil` (which holds
relevant logic) to `api`, which required moving more classes. Specifically, I
am talking about `Partitioning` and `MetadataColumns`. I am thinking about
alternatives. I could add a brand new `ScanTaskUtil` in `api`, but it is a bit
awkward to have both.
Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
