flyrain commented on code in PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#discussion_r1826606339
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -93,7 +94,8 @@ protected DeleteFilter(
this.posDeletes = posDeleteBuilder.build();
this.eqDeletes = eqDeleteBuilder.build();
- this.requiredSchema = fileProjection(tableSchema, requestedSchema,
posDeletes, eqDeletes);
+ this.requiredSchema =
+ fileProjection(tableSchema, requestedSchema, posDeletes, eqDeletes,
isBatchReading);
Review Comment:
One question I asked myself is whether it impacts the metadata column read?
It seems not, but the method `DeleteFilter::fileProjection` seems a bit hard to
read, we can refactor it later. It makes more sense to make it a static until
method instead of instance method. Plus, it's a bit weird to pass the schema to
delete filter, then get it back from the filter. This seems something we can
improve on it as a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
