arkadius commented on code in PR #11249:
URL: https://github.com/apache/iceberg/pull/11249#discussion_r1827929674
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkDistributionMode.java:
##########
@@ -118,9 +118,15 @@ public void before() throws IOException {
public void testShuffleByPartitionWithSchema() throws Exception {
testWriteRow(parallelism, SimpleDataUtil.FLINK_SCHEMA,
DistributionMode.HASH);
if (partitioned) {
- assertThat(partitionFiles("aaa")).isEqualTo(1);
- assertThat(partitionFiles("bbb")).isEqualTo(1);
- assertThat(partitionFiles("ccc")).isEqualTo(1);
+ assertThat(partitionFiles("aaa"))
+ .as("There should be only 1 data file in partition 'aaa'")
+ .isEqualTo(1);
+ assertThat(partitionFiles("bbb"))
+ .as("There should be only 1 data file in partition 'bbb'")
+ .isEqualTo(1);
+ assertThat(partitionFiles("ccc"))
+ .as("There should be only 1 data file in partition 'ccc'")
+ .isEqualTo(1);
Review Comment:
I can't answer on this question because I'm not up-to-date with assertj. I
copied it from this PR:
https://github.com/apache/iceberg/pull/10179/files#diff-42c31c3c7e3e8287ea451196f6c0b4d0a47aa931391df70369a87ed3d19a1452R221
@rodmeneses copied this code for SinkV2 and (I assume) forgot to backport it
to the original source of the code. We can synchronize it in the opposite
direction (remove these explanations from duplicated places) if we find out
that it doesn't add a value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
