danielcweeks commented on code in PR #11463:
URL: https://github.com/apache/iceberg/pull/11463#discussion_r1828272218
##########
core/src/main/java/org/apache/iceberg/deletes/BitmapPositionDeleteIndex.java:
##########
@@ -43,6 +53,11 @@ class BitmapPositionDeleteIndex implements
PositionDeleteIndex {
this.deleteFiles = deleteFile != null ? Lists.newArrayList(deleteFile) :
Lists.newArrayList();
}
+ BitmapPositionDeleteIndex(RoaringPositionBitmap bitmap, DeleteFile
deleteFile) {
+ this.bitmap = bitmap;
+ this.deleteFiles = deleteFile != null ? Lists.newArrayList(deleteFile) :
Lists.newArrayList();
Review Comment:
Is there a case where we can have a deserialized bitmap, but no delete file?
Just wondering if we should have a separate constructor or if it makes sense
to allow passing null for those cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
