jbonofre commented on code in PR #11461:
URL: https://github.com/apache/iceberg/pull/11461#discussion_r1829706396
##########
site/docs/how-to-release.md:
##########
@@ -435,10 +435,10 @@ spark-shell \
To verify using Flink, start a Flink SQL Client with the following command:
```bash
-wget ${MAVEN_URL}/iceberg-flink-runtime/{{ icebergVersion
}}/iceberg-flink-runtime-{{ icebergVersion }}.jar
+wget ${MAVEN_URL}/iceberg-flink-runtime-${FLINK_VERSION}/{{ icebergVersion
}}/iceberg-flink-runtime-${FLINK_VERSION}-{{ icebergVersion }}.jar
Review Comment:
Same question here about `FLINK_VERSION`. I would add a note indicating the
user has to define the variables.
##########
site/docs/how-to-release.md:
##########
@@ -422,7 +422,7 @@ spark-runtime jar for the Spark installation):
```bash
spark-shell \
--conf spark.jars.repositories=${MAVEN_URL} \
- --packages org.apache.iceberg:iceberg-spark3-runtime:{{ icebergVersion }} \
+ --packages
org.apache.iceberg:iceberg-spark-runtime-${SPARK_VERSION}_${SCALA_VERSION}:{{
icebergVersion }} \
Review Comment:
I guess it's up to the user to populate `SPARK_VERSION` and `SCALA_VERSION`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
