openinx commented on a change in pull request #1332:
URL: https://github.com/apache/iceberg/pull/1332#discussion_r471901135
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -71,6 +72,8 @@
*/
public class FlinkCatalog extends AbstractCatalog {
+ private final CatalogLoader catalogLoader;
+ private final Configuration hadoopConf;
Review comment:
Those two seems don't have to be private members because I did not see
anywhere accessing them except the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
