aihuaxu commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1831845888
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionUtil.java:
##########
@@ -562,7 +563,7 @@ private static String sanitize(Literal<?> literal, long
now, int today) {
} else if (literal instanceof Literals.DoubleLiteral) {
return sanitizeNumber(((Literals.DoubleLiteral) literal).value(),
"float");
} else {
- // for uuid, decimal, fixed, and binary, match the string result
+ // for uuid, decimal, fixed, variant, and binary, match the string result
Review Comment:
Actually to support this, we need to have defined the interface
`VariantLike` on how to access the subfields and then recursively sanitize the
values based on the subfield types.
When we promote the VariantLike to API, then we can add such implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
