RussellSpitzer commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1833022565
##########
api/src/main/java/org/apache/iceberg/transforms/Identity.java:
##########
@@ -38,6 +38,9 @@ class Identity<T> implements Transform<T, T> {
*/
@Deprecated
public static <I> Identity<I> get(Type type) {
+ Preconditions.checkArgument(
+ type.typeId() != Type.TypeID.VARIANT, "Unsupported type for identity:
%s", type);
Review Comment:
We do only need to special case it if we make Variant a primitive. I'm not
sure what primitive really means in this context though. I think anything that
may or may not be scalar is probably not a primitive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
